Allow writing into Delta tables using deletion vectors #21784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/delta-write-without-dv
branch
from
ba631f5
to
ec8aadf
Compare
ebyhr
force-pushed
the
ebi/delta-write-without-dv
branch
from
ec8aadf
to
71d0286
Compare
ebyhr
commented
May 1, 2024
|
|
||
| assertUpdate("MERGE INTO " + tableName + " t USING " + tableName + " s " + | ||
| "ON (t.a = s.a) WHEN MATCHED THEN UPDATE SET b = -1", 2); | ||
| assertQuery("SELECT * FROM " + tableName, "VALUES (1, -1), (-3, -1)"); |
There was a problem hiding this comment.
Reading logic for deletion vectors might be broken though I'm not sure if Databricks writes such transaction logs:
java.lang.AssertionError: For query 20240501_092829_00018_hvqds:
SELECT * FROM deletion_vectorsg763ca8zs4
not equal
Actual rows (up to 100 of 1 extra rows shown, 3 rows in total):
[2, 22]
Expected rows (up to 100 of 0 missing rows shown, 2 rows in total):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR doesn't writing deletion vectors. Still rewriting whole files.
Relates to #17063
Release notes
(x) Release notes are required, with the following suggested text: