-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Databricks runtime 14.3 & 15.4 LTS #21700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
It seems 14.3 LTS enabled deletion vectors by default: https://github.com/trinodb/trino/actions/runs/8840347798/job/24275694250?pr=21700. Some tests started failing due to unsupported writer feature. |
Hey, is someone workign on this? Support of deletion vectors would be highly appreciated |
0efda1c
to
9bb5b06
Compare
@benbauer-draeger This PR just adds a new CI environment of Databricks 14.3 LTS. #22102 to support writing deletion vectors was already merged in version 454. |
00eb4ff
to
762c709
Compare
a794f63
to
c5df088
Compare
@@ -330,7 +331,7 @@ public void testInsertingIntoDatabricksTableWithAddedNotNullConstraint() | |||
} | |||
} | |||
|
|||
@Test(groups = {DELTA_LAKE_DATABRICKS, PROFILE_SPECIFIC_TESTS}) | |||
@Test(groups = {DELTA_LAKE_DATABRICKS_104, PROFILE_SPECIFIC_TESTS}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connector doesn't support VACUUM with deletion vector, so I specified the old version here. Added a comment to revert this change in #22809.
Are you sure we dont want a release notes entry for this @ebyhr and @findinpath ? |
@mosabua We don't need a release note entry because this PR changed only tests. |
ok .. thanks @ebyhr |
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.