Configure worker threads relative to core count #20772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker threads defaults to 2*#cores. This commit allows configuration to be #cores based too. Extracted from trinodb#16303 Co-authored-by: Mateusz "Serafin" Gajewski <[email protected]>
wendigo
approved these changes
Feb 20, 2024
sopel39
reviewed
Feb 20, 2024
| @@ -286,9 +286,9 @@ public int getMaxWorkerThreads() | |||
|
|
|||
| @LegacyConfig("task.shard.max-threads") | |||
| @Config("task.max-worker-threads") | |||
| public TaskManagerConfig setMaxWorkerThreads(int maxWorkerThreads) | |||
| public TaskManagerConfig setMaxWorkerThreads(String maxWorkerThreads) | |||
There was a problem hiding this comment.
Can we add @ConfigDescription and documentation ?
Maybe also deprecate task.shard.max-threads in another commit
There was a problem hiding this comment.
Maybe also deprecate
task.shard.max-threadsin another commit
that's orthogonal, i believe?
|
I think it should accept decimal number for better configurability. |
i didn't have a use-case for this. note that effective configuration should be exact, whole number of threads, so we don't want floating point arithmetics semantics. |
findepi
deleted the
findepi/configure-worker-threads-relative-to-core-count-144a9e
branch
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
May 22, 2024
6 tasks
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
May 24, 2024
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
May 24, 2024
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
May 24, 2024
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
May 28, 2024
arhimondr
added a commit
to prestodb/presto
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker threads defaults to 2*#cores. This commit allows configuration to be #cores based too.
Extracted from #16303