Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax in PredicatePushDown#createDynamicFilters arguments list #19528

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix syntax in PredicatePushDown#createDynamicFilters arguments list #19528

merged 1 commit into from
Oct 26, 2023

Conversation

radek-kondziolka
Copy link
Contributor

Description

Fix syntax in PredicatePushDown#createDynamicFilters arguments list

Release notes

(* ) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2023
raunaqmorarka
raunaqmorarka approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably say "Fix formatting/indentation", not syntax as that sounds like a compiler error

@wendigo wendigo merged commit 6d55b65 into trinodb:master Oct 26, 2023
88 of 89 checks passed
@github-actions github-actions bot added this to the 431 milestone Oct 26, 2023
@mosabua mosabua mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
431
Development

Successfully merging this pull request may close these issues.
3 participants
@radek-kondziolka @wendigo @raunaqmorarka