Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase split processing config parameters #19487

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Dith3r
Copy link
Member

@Dith3r Dith3r commented Oct 23, 2023

Description

Improve query performance with easy to process splits by increasing the number of splits assigned, and makes initial worker split concurrency two times higher, but much slower to be adjusted (increased) based on memory utilization.

Salesforce benchmark:
image
c_sales.pdf

Hive/parquet/part:
image
c_hive_par_part.pdf

Hive/parquet/unpart:
image
c_hive_par_unpart.pdf

Iceberg/parquet/part:
image
c_iceberg_par_part.pdf

Iceberg/parquet/unpart:
image
c_iceberg_par_unpart.pdf

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Improve performance of queries with short running splits. ({issue}`19487`)

Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that any documentation around these properties gets an update and add release notes entry to the PR description.

Improve query performance with easy to process splits by
increasing the number of splits assigned.
@github-actions github-actions bot added the docs label Oct 23, 2023
@raunaqmorarka raunaqmorarka merged commit 306bb37 into trinodb:master Oct 26, 2023
92 checks passed
@github-actions github-actions bot added this to the 431 milestone Oct 26, 2023
@xiacongling
Copy link
Contributor

hi, @Dith3r . Links cannot be opened (http 404). Can you fix them (may need to make them public). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants