Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal Block interface #19480

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Seal Block interface #19480

merged 2 commits into from
Oct 22, 2023

Commits on Oct 21, 2023

  1. Remove unnecessary VariableWidthBlock subclass in TestDictionaryBuilder

    @dain
    dain committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    32948a2 View commit details
    Browse the repository at this point in the history

  2. Only allow ValueBlock implementations of Block 

    The synthetic dictionary, rle, and lazy blocks require special handling
in the codebase, and new synthetic blocks cannot reasonable be added
without updating the existing code. This commit blocks direct extensions
of Block, only allowing extensions to ValueBlock.

Seal Block interface
Mark ValueBlock interface non-sealed
Mark all current ValueBlock implementations as final
    @dain
    dain committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    af9b9d0 View commit details
    Browse the repository at this point in the history