Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert cleanups #19147

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Insert cleanups #19147

merged 5 commits into from
Sep 25, 2023

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Sep 25, 2023

Follow-up to #18771

@@ -3510,7 +3510,7 @@ private int getWriterCount(Session session, WriterScalingOptions connectorScalin
// The default value of partitioned writer count is 32 which is high enough to use it
// for both cases when scaling is enabled or not. Additionally, it doesn't lead to too many
// small files since when scaling is disabled only single writer will handle a single partition.
int partitionedWriterCount = getTaskWriterCount(session);
int partitionedWriterCount = getTaskPartitionedWriterCount(session);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth testing ?

@github-actions github-actions bot added the docs label Sep 25, 2023
@sopel39 sopel39 merged commit 9e48b3f into trinodb:master Sep 25, 2023
92 of 93 checks passed
@sopel39 sopel39 deleted the ks/fixups branch September 25, 2023 17:57
@github-actions github-actions bot added this to the 427 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants