Avoid re-reading parquet footer for iceberg stats in writer #19090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
electrum,
sopel39,
findepi,
ebyhr and
findinpath
github-actions
bot
added
tests:hive
iceberg
sopel39
approved these changes
Sep 19, 2023
findinpath
reviewed
Sep 19, 2023
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergParquetFileWriter.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public Metrics getMetrics() | ||
| { | ||
| return fileMetrics(inputFile, metricsConfig); |
There was a problem hiding this comment.
Add a test for your improvement in io.trino.plugin.iceberg.TestIcebergMetadataFileOperations
There was a problem hiding this comment.
TestIcebergMetadataFileOperations seems to be specifically about metadata operations, this is a "DATA" operation.
There is code preventing assertions on DATA operations at
There was a problem hiding this comment.
you're right. we can either broaden the test class coverage (rename class to match data operations too)
or add similar class, a copy
or abstain from testing
There was a problem hiding this comment.
I'm skipping testing access count explicitly for now
raunaqmorarka
force-pushed
the
ice-writer-footer
branch
from
373871e
to
6e641c5
Compare
ebyhr
approved these changes
Sep 20, 2023
findepi
reviewed
Sep 20, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergParquetFileWriter.java
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
ice-writer-footer
branch
from
6e641c5
to
cc242ab
Compare
findepi
reviewed
Sep 20, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergParquetFileWriter.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergParquetFileWriter.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Show resolved
Hide resolved
Composition is generally preferred over inheritance for reusing code
raunaqmorarka
force-pushed
the
ice-writer-footer
branch
from
cc242ab
to
d3654e5
Compare
Currently we're reading parquet file footer back just after writing it to file system for computing iceberg stats. Since Trino parquet writer already has the file footer, there is no need to perform an extra IO to get the footer again.
raunaqmorarka
force-pushed
the
ice-writer-footer
branch
from
d3654e5
to
5e4bee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we're reading parquet file footer back just after
writing it to file system for computing iceberg stats.
Since Trino parquet writer already has the file footer, there
is no need to perform an extra IO to get the footer again.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: