Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract constants for table feature names in Delta Lake #19083

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Extract constants for table feature names in Delta Lake #19083

merged 1 commit into from
Sep 20, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 19, 2023

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2023
@github-actions github-actions bot added the delta-lake Delta Lake connector label Sep 19, 2023
@ebyhr ebyhr self-assigned this Sep 19, 2023
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Sep 19, 2023
@ebyhr ebyhr changed the title Extract enum for table features in Delta Lake Extract constants for table feature names in Delta Lake Sep 19, 2023
@ebyhr ebyhr requested a review from findepi September 19, 2023 21:55
findepi
findepi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent.

I liked the enum-based approach better, but i know it needed more work. We can always do this later.

@ebyhr ebyhr merged commit fb277f1 into trinodb:master Sep 20, 2023
22 checks passed
@ebyhr ebyhr deleted the ebi/delta-table-features branch September 20, 2023 09:57
@github-actions github-actions bot added this to the 427 milestone Sep 20, 2023
@colebow colebow mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@findepi findepi findepi approved these changes

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees

@ebyhr ebyhr

Labels
cla-signed delta-lake Delta Lake connector no-release-notes This pull request does not require release notes entry
Milestone
427
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @findepi @findinpath