Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong time unit used for reporting elapsed time in query planing #19047

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

weiatwork
Copy link
Contributor

Description

The number for elapsed time should be changed back to milli-seconds from nanoseconds. This was an oversight caused by #16365.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link

cla-bot bot commented Sep 14, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Wei Zheng.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@electrum
Copy link
Member

The commit message title is too long (notice how GitHub wraps it). Please see these guidelines: https://cbea.ms/git-commit/

@martint martint merged commit 0b8f09f into trinodb:master Sep 15, 2023
86 checks passed
@github-actions github-actions bot added this to the 427 milestone Sep 15, 2023
@weiatwork weiatwork deleted the ns-ms branch September 15, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants