Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SQL support section #19000

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

Jessie212
Copy link
Contributor

Description

  • Removed duplicate content and rearranged SQL section.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Updating data" and "Data management" sections are duplicate content we should consolidate under "Data management".

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more rejigging needed

@Jessie212
Copy link
Contributor Author

@mosabua Does everything in this section makes sense in this order?

@mosabua
Copy link
Member

mosabua commented Sep 12, 2023

@mosabua Does everything in this section makes sense in this order?

Kind of .. proecedures is a bit odd and could be later .. but lets leave it for now

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now.

@mosabua mosabua merged commit 23341c4 into trinodb:master Sep 13, 2023
2 checks passed
@github-actions github-actions bot added this to the 427 milestone Sep 13, 2023
@Jessie212 Jessie212 deleted the jt/delta-lake-sql branch September 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants