Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include enabled roles in QueryContext for event listeners #18994

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ksobolew
Copy link
Contributor

Description

It's odd that it included the principal and groups, but not enabled roles.

Additional context and related issues

This information is definitely useful for some event listeners.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

It's odd that it included the principal and groups, but not enabled
roles.
@findepi
Copy link
Member

findepi commented Sep 11, 2023

Copy link
Member

@djsstarburst djsstarburst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to have visibility into the enabled roles if available, so I approved.

HOWEVER, I have made a (so far unsuccessful) effort to optimize out calling listEnabledRoles for every query.

If you have any suggestions to debug problems like this optimization I'd like to hear them. The PR feels a bit foolish to me - - but I couldn't think of another way to gain insight.

@ksobolew
Copy link
Contributor Author

Huh. And here I thought that it's just list a list of names :) I should have known better, I did look at that HTTP context factory before...

@ksobolew
Copy link
Contributor Author

Green and ready to be merged

@kokosing kokosing merged commit 7d36ed5 into trinodb:master Sep 15, 2023
86 checks passed
@github-actions github-actions bot added this to the 427 milestone Sep 15, 2023
@ksobolew ksobolew deleted the kudi/add-enabled-roles-to-context branch September 15, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants