Add coercion test coverage for Sequence file #18921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
atanasenko,
kokosing,
krvikash,
vlad-lyutenko,
marcinsbd and
raunaqmorarka
|
Is it extension to some PR? |
It is actually an independent PR but it helps for #18832. |
atanasenko
approved these changes
Sep 5, 2023
| @@ -231,7 +231,7 @@ protected Map<String, List<Object>> expectedValuesForEngineProvider(Engine engin | |||
| { | |||
| String hiveValueForCaseChangeField; | |||
| Predicate<String> isFormat = formatName -> tableName.toLowerCase(ENGLISH).contains(formatName); | |||
| if (isFormat.test("rctext") || isFormat.test("textfile")) { | |||
| if (isFormat.test("rctext") || isFormat.test("textfile") || isFormat.test("sequencefile")) { | |||
There was a problem hiding this comment.
Suggested change
| if (isFormat.test("rctext") || isFormat.test("textfile") || isFormat.test("sequencefile")) { | |
| if (Arrays.asList("rctext", "textfile", "sequencefile").contains(isFormat)) { |
There was a problem hiding this comment.
nit: Easier to read than 3+ conditions.
There was a problem hiding this comment.
Since we need to match for the tableName pattern I have modified to use Stream here
vlad-lyutenko
approved these changes
Sep 5, 2023
Praveen2112
force-pushed
the
praveen/additional_coercion_test_coverage
branch
from
fc296c3
to
50a04a3
Compare
kokosing
approved these changes
Sep 5, 2023
ebyhr
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional coercion test coverage for Sequence file
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.