Execute testDynamicFiltering* exclusively
#18850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
approved these changes
Aug 30, 2023
| PARTITIONED, | ||
| isAggregationPushedDown); | ||
| executeExclusively(() -> { | ||
| MaterializedResultWithQueryId resultWithQueryId = getDistributedQueryRunner() |
There was a problem hiding this comment.
please extract methods instead of long lambdas. The diff will be more human friendly.
There was a problem hiding this comment.
For extracted methods I'll add Flaky suffix for existing method names
There was a problem hiding this comment.
Please don't. Flaky "means" non deterministic. Whereas we know how it behaves and it is deterministic. I think the better name would be Unsafe which is common term in regards to concurrency. However here I think a code comment would be simply the best.
There was a problem hiding this comment.
Method signatures are the same as of original methods, so I've used Unsafe suffix.
This should mitigate flakiness. Relates to f3c41a4
ssheikin
force-pushed
the
ssheikin/383/trino/flaky_testDynamicFiltering3
branch
from
c77a9b8
to
c886e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mitigate flakiness.
Relates to f3c41a4
#18323
#18499
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: