Coerce column type varchar0 to varchar1 for hive table #18811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinsbd
force-pushed
the
coerce-column-type-varchar0-to-varchar1-for-Hive-table
branch
from
618ad40
to
aabac31
Compare
marcinsbd
requested review from
krvikash,
kokosing,
Praveen2112,
atanasenko and
vlad-lyutenko
kokosing
approved these changes
Sep 6, 2023
findepi
reviewed
Sep 6, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
Please fill-in (or remove from PR description). in any case, please expand PR description to say what's the effect of the changes. |
marcinsbd
force-pushed
the
coerce-column-type-varchar0-to-varchar1-for-Hive-table
branch
from
aabac31
to
02bc5db
Compare
krvikash
approved these changes
Sep 8, 2023
atanasenko
approved these changes
Sep 15, 2023
kokosing
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of the PR is to auto-adjust column type from varchar(0) to varchar(1) for Hive connector.
The min len of the Trino SPI's VarchartType is 0 whereas the min len of Hive's varchar type is 1.
Additional context and related issues
Release notes
( ) Release notes are required, with the following suggested text: