Enable parallel option in Delta Lake product tests #18750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/delta-pt-speed
branch
from
b6b90b5
to
083a80c
Compare
Closed
wendigo
approved these changes
Aug 21, 2023
|
Does it work as expected? How can I verify that test indeed was executed in parallel? |
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/delta-pt-speed
branch
from
083a80c
to
fa98258
Compare
findinpath
reviewed
Aug 21, 2023
| @@ -164,7 +164,7 @@ | |||
| <dep.jsonwebtoken.version>0.11.5</dep.jsonwebtoken.version> | |||
| <dep.oracle.version>21.9.0.0</dep.oracle.version> | |||
| <dep.drift.version>1.21</dep.drift.version> | |||
| <dep.tempto.version>200</dep.tempto.version> | |||
| <dep.tempto.version>201</dep.tempto.version> | |||
There was a problem hiding this comment.
Notes for other reviewers: relates to trinodb/tempto#122
The log indicates tests ran in parallel. However, |
ebyhr
force-pushed
the
ebi/delta-pt-speed
branch
2 times, most recently
from
5f47a00
to
82f97d5
Compare
ebyhr
force-pushed
the
ebi/delta-pt-speed
branch
2 times, most recently
from
fb550db
to
e50229f
Compare
This reverts commit 0d63491204ba3efa96abd5ac7f65b6fb50d033b5.
ebyhr
force-pushed
the
ebi/delta-pt-speed
branch
from
e50229f
to
49d06be
Compare
|
Closing as we're trying a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delta Product tests sometimes take 2 hours in total.
Relates to #18805
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.