Updated docs for PEM format support #18635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wdyt @electrum ? |
electrum
approved these changes
Aug 29, 2023
docs/src/main/sphinx/security/tls.md
Outdated
| @@ -221,7 +221,7 @@ Relative paths are relative to the Trino server's root directory. In a | |||
| `tar.gz` installation, the root directory is one level above `etc`. | |||
|
|
|||
| JKS keystores always require a password, while PEM format certificates can | |||
There was a problem hiding this comment.
How about
JKS keystores always require a password, while PEM files with passwords are not supported by Trino. For JKS, add the following line to the configuration:
Note that the wording "PEM certificate" in this document is not really correct, since a PEM file used as a keystore will contain both a private key and a certificate. But we can address that as a follow up.
There was a problem hiding this comment.
Updated .. and will do follow up PR for the file vs certificate
- Specifically add that password protected PEM files are not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifically add that password protected PEM files are not supported.
FYI jdsjdk
Additional context and related issues
Result of discussion in #17300
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.