-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy Hive readers and writers #18241
Conversation
df7e9d5
to
7de468b
Compare
6e00005
to
b3dba79
Compare
...rino-hive/src/test/java/io/trino/plugin/hive/TestParquetPageSkippingWithOptimizedReader.java
Outdated
Show resolved
Hide resolved
5bcb6cf
to
24cbba5
Compare
ecd6431
to
490b88e
Compare
490b88e
to
815723f
Compare
Ihave two questions, Will the s3 select pushdown feature come back ? Will s3 select pushdown feature support parquet file pushdown? |
@awakeljw We have no plans to reimplement S3 Select. For Parquet, the results are returned as CSV or JSON, which is why it was never implemented in Trino. The feature introduces significant complexity in Trino and only benefits textfile formats. Additionally, the pricing model for S3 Select seems to put it at a disadvantage compared to simply increasing compute on the Trino side. Thus, we don't believe it is worth the complexity and maintenance burden. |
Description
This PR will be merged once we have confidence in the new readers and writers.
Release notes
(x) Release notes are required, with the following suggested text: