Support writing timestamp with timezone in BigQuery

[regadas]

Description

Relates to #13741

Release notes

(x) Release notes are required, with the following suggested text:

# BigQuery
* Add support for writing `timestamp with time zone` type. ({issue}`17793`)

Addressed.

[regadas]

Hi @ebyhr can you take another look? thank you

[ebyhr]

/test-with-secrets sha=4fdb7eb72775cb8a3de06c0a243b78b9b6913a30

[github-actions]

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5316983873

[ebyhr]

@regadas Please confirm the above CI failure. Some failure come from BigQuery SLA, but TestBigQueryAvroConnectorTest.testDataMappingSmokeTest failure looks related to this change.

[regadas]

@ebyhr hm this seems a BQ related issue (probably due to resource availability for the project used). I'll rerun the tests on my side to confirm.

[regadas]

yup all good

[INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 355.769 s - in io.trino.plugin.bigquery.TestBigQueryAvroTypeMapping
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:08 min (Wall Clock)
[INFO] Finished at: 2023-06-19T21:23:31-04:00
[INFO] ------------------------------------------------------------------------
[WARNING] 
[WARNING] Plugin validation issues were detected in 4 plugin(s)
[WARNING] 
[WARNING]  * com.hubspot.maven.plugins:dependency-scope-maven-plugin:0.10
[WARNING]  * org.jacoco:jacoco-maven-plugin:0.8.10
[WARNING]  * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
[WARNING]  * org.codehaus.mojo:build-helper-maven-plugin:3.3.0
[WARNING] 
[WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
[WARNING] 

[ebyhr]

this seems a BQ related issue

No, testDataMappingSmokeTest failure is related to this change.

[ebyhr]

[INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 355.769 s - in io.trino.plugin.bigquery.TestBigQueryAvroTypeMapping

The test is wrong. Please confirm TestBigQueryAvroConnectorTest.

[regadas]

No, testDataMappingSmokeTest failure is related to this change.

unsure really because the logs do have

Caused by: com.google.cloud.bigquery.BigQueryException: 502 Bad Gateway

[ebyhr]

Please take a look at:

Error:  Failures: 
Error:    TestBigQueryAvroConnectorTest>BaseConnectorTest.testDataMappingSmokeTest:5078->BaseConnectorTest.testDataMapping:5108->BaseConnectorTest.lambda$testDataMapping$67:5101->AbstractTestQueryFramework.assertUpdate:405->AbstractTestQueryFramework.assertUpdate:410 » QueryFailed An internal error occurred and the request could not be completed. This is usually caused by a transient issue. Retrying the job with back-off as described in the BigQuery SLA should solve the problem: https://cloud.google.com/bigquery/sla. If the error continues to occur please contact support at https://cloud.google.com/support.
Error:    TestBigQueryAvroConnectorTest>BaseConnectorTest.testDataMappingSmokeTest:5078->BaseConnectorTest.testDataMapping:5113->AbstractTestQueryFramework.assertQuery:339 For query 20230620_001638_01284_uyiad: 
 SELECT row_id FROM test_data_mapping_smoke_timestamp_6__with_time_zone5njyehw04u WHERE rand() = 42 OR value = TIMESTAMP '1969-12-31 15:03:00.123456 +01:00'
not equal
Actual rows (up to 100 of 0 extra rows shown, 0 rows in total):
    
Expected rows (up to 100 of 1 missing rows shown, 1 rows in total):
    [sample value]

Error:    TestBigQueryAvroConnectorTest>BaseConnectorTest.testDataMappingSmokeTest:5078->BaseConnectorTest.testDataMapping:5113->AbstractTestQueryFramework.assertQuery:339 For query 20230620_001800_01293_uyiad: 
 SELECT row_id FROM test_data_mapping_smoke_timestamp_6__with_time_zone7n85c1xvdz WHERE rand() = 42 OR value = TIMESTAMP '2020-02-12 15:03:00 +01:00'
not equal
Actual rows (up to 100 of 0 extra rows shown, 0 rows in total):
    
Expected rows (up to 100 of 1 missing rows shown, 1 rows in total):
    [sample value]

[regadas]

Will do! the 502 could be a red herring.

is there a faster way to run testDataMappingSmokeTest? the other one is still going

[regadas]

Hi @ebyhr can you take another look at this? Thank you 🙏

[ebyhr]

/test-with-secrets sha=e47f908d3ac06578266c586cff24d682512f1db3

[github-actions]

The CI workflow run with tests that require additional secrets finished as : https://github.com/trinodb/trino/actions/runs/5383558308

[wendigo]

/test-with-secrets sha=e47f908d3ac06578266c586cff24d682512f1db3

[ebyhr]

It seems tests with secret didn't start correctly. I will re-trigger.
cc: @nineinchnick

[ebyhr]

/test-with-secrets sha=e47f908d3ac06578266c586cff24d682512f1db3

[nineinchnick]

https://github.com/trinodb/trino/actions/runs/5476655936/jobs/9974512729#step:3:16
@wendigo permissions were not correct at that time.

[github-actions]

The CI workflow run with tests that require additional secrets finished as : https://github.com/trinodb/trino/actions/runs/5482967673

[nineinchnick]

The workflow with secrets failed because there's an invalid condition, here's a fix: #18165

[ebyhr]

#12346