Fix iceberg v2 table with equality delete can't update #16216
Closed
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heltman
force-pushed
the
iceberg_update_fix
branch
from
318e204
to
d9d7dfb
Compare
ebyhr
reviewed
May 16, 2023
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
Feel free to reopen or take over in new PR as desired @ebyhr @Heltman also cc @findepi @electrum @brandylove |
|
Is there any plan to release this fix on Trino..? |
|
@Heltman Could you rebase on master to resolve conflicts? |
Heltman
force-pushed
the
iceberg_update_fix
branch
from
d9d7dfb
to
6c4f5dc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ebyhr
added
the
stale-ignore
ebyhr
force-pushed
the
iceberg_update_fix
branch
2 times, most recently
from
59c29a6
to
ba17679
Compare
ebyhr
force-pushed
the
iceberg_update_fix
branch
from
ba17679
to
3cc9374
Compare
ebyhr
reviewed
Nov 6, 2024
| // If column is rowIdColumn, we should not create a field with its actual type, because column id will conflict | ||
| // with a real column. We just use boolean type make a fake. | ||
| if (column.isUpdateRowIdColumn() || column.isMergeRowIdColumn()) { | ||
| field = NestedField.optional(column.getId(), column.getName(), toIcebergType(BOOLEAN, column.getColumnIdentity())); |
There was a problem hiding this comment.
@Heltman Excluding this column instead of a fake column doesn't work?
|
Superseded by #24062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When iceberg v2 table has equality delete file, update will failed.
Fixes #15952
Release notes