Support table redirections from Hive to Hudi #15551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx123
changed the title
mx123
force-pushed
the
hive_hudi_redirections
branch
5 times, most recently
from
3e8f4ee to
dffddb1
Compare
|
Build is red during Also please rebase on |
mx123
force-pushed
the
hive_hudi_redirections
branch
4 times, most recently
from
e2a79a6 to
23e6292
Compare
fixed
done |
mx123
force-pushed
the
hive_hudi_redirections
branch
from
23e6292 to
2e79834
Compare
|
Please squash the first 2 commits. |
findinpath
approved these changes
Jan 4, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Show resolved
Hide resolved
mx123
force-pushed
the
hive_hudi_redirections
branch
7 times, most recently
from
5d08bf3 to
981ad14
Compare
findinpath
reviewed
Jan 9, 2023
findepi
reviewed
Jan 9, 2023
|
@codope CPTAL whether we did cover all the possible cases for identifying whether we're dealing with a Hudi table in |
mx123
force-pushed
the
hive_hudi_redirections
branch
2 times, most recently
from
1b85603 to
b355636
Compare
findinpath
reviewed
Jan 12, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 12, 2023
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 12, 2023
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 12, 2023
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Jan 12, 2023
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
mx123
force-pushed
the
hive_hudi_redirections
branch
4 times, most recently
from
6b99110 to
ff454e5
Compare
ebyhr
reviewed
Jan 13, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Show resolved
Hide resolved
...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToHudi.java
Show resolved
Hide resolved
ebyhr
reviewed
Jan 13, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
mx123
force-pushed
the
hive_hudi_redirections
branch
2 times, most recently
from
b70b33a to
2435a8c
Compare
Added minimal config testing and modified to comply Trino code standards of original PR: trinodb#14349
mx123
force-pushed
the
hive_hudi_redirections
branch
from
2435a8c to
c2bfca3
Compare
ebyhr
approved these changes
Jan 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to run queries referencing a single hive catalog to access both normal hive tables and hudi tables with new optimised+dedicated connector (provided an admin has configured hive.hudi-catalog-name to point to a hudi catalog).
Original pull request: #14349
Fixes #14750