Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ST_Length(SphericalGeography) #1551

Closed
wants to merge 2 commits into from

Conversation

jlabarbera11
Copy link
Member

Adds ST_Length(SphericalGeography) which computes the length of a LINESTRING on the surface of a spherical model of Earth's surface, i.e. the sum of great-circle distances between adjacent points along the linestring.

Based on prestodb/presto#12552

@cla-bot
Copy link

cla-bot bot commented Sep 18, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@findepi
Copy link
Member

findepi commented Sep 18, 2019

@jlabarbera11 thanks for your PR!

Please make sure you sign the CLA (https://github.com/prestosql/cla).

Also, when contributing someone else's work, make sure to attribute it:

git commit --amend --author 'Sean Barker <[email protected]>' -m 'Add ST_Length(SphericalGeography)

Extracted-From: https://github.com/prestodb/presto'

Please ping me on slack (https://prestosql.io/community.html) if you need any help.

@martint
Copy link
Member

martint commented Sep 18, 2019

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2019
@cla-bot
Copy link

cla-bot bot commented Sep 18, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot
Copy link

cla-bot bot commented Sep 18, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@cla-bot cla-bot bot removed the cla-signed label Sep 18, 2019
@cla-bot
Copy link

cla-bot bot commented Sep 18, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/prestosql/cla.

@martint martint mentioned this pull request Sep 20, 2019
6 tasks
@martint martint added this to the 319 milestone Sep 20, 2019
@martint
Copy link
Member

martint commented Sep 20, 2019

Merged, thanks!

@martint martint closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants