Support field separator for Hive TEXTFILE #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
force-pushed
the
origin/master/161_hive_field_separator
branch
from
c2fedef
to
9441119
Compare
findepi
approved these changes
Sep 11, 2019
| return getTextFormatProperty(tableProperties, TEXTFILE_FIELD_SEPARATOR_ESCAPE); | ||
| } | ||
|
|
||
| private static Optional<Character> getTextFormatProperty(Map<String, Object> tableProperties, String key) |
There was a problem hiding this comment.
getTextFormat*Separator*Property ?
also, isn't this equivalent to, but implemented differently than, getCsvSerdeProperty?
|
|
||
| @Language("SQL") String createTableSql = format("" + | ||
| "CREATE TABLE %s.%s.test_create_external (\n" + | ||
| " name varchar\n" + | ||
| " action varchar,\n" + | ||
| " object varchar\n" + |
There was a problem hiding this comment.
object -> name
object may look like some weird data type
kokosing
force-pushed
the
origin/master/161_hive_field_separator
branch
from
9441119
to
e22f096
Compare
kokosing
force-pushed
the
origin/master/161_hive_field_separator
branch
from
e22f096
to
6d248f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support field separator for Hive TEXTFILE