Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support case insensitive metric names in Prometheus #13745

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Support case insensitive metric names in Prometheus #13745

merged 2 commits into from
Aug 30, 2022

Conversation

lshmouse
Copy link
Contributor

@lshmouse lshmouse commented Aug 19, 2022 •
edited by ebyhr
Loading

Description

Support case insensitive metric names in Prometheus

Is this change a fix, improvement, new feature, refactoring, or other?

improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

prometheus connector

How would you describe this change to a non-technical end user or system administrator?

Support to query metrics with upper-case letter names in presto

Related issues, pull requests, and links

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) Release notes entries required with the following suggested text:

Add prometheus.case-insensitive-name-matching option in prometheus connector to support query metrics with with upper-case letter names

# Prometheus
* Add support for case-insensitive table name matching via the `prometheus.case-insensitive-name-matching` configuration property. ({issue}`8740`)

@cla-bot
Copy link

cla-bot bot commented Aug 19, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shaohui Liu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 19, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Aug 19, 2022
@ebyhr ebyhr self-requested a review August 19, 2022 07:30
ebyhr
ebyhr approved these changes Aug 19, 2022
View reviewed changes
docs/src/main/sphinx/connector/prometheus.rst Show resolved Hide resolved
docs/src/main/sphinx/connector/prometheus.rst Outdated Show resolved Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusClient.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
...heus/src/test/java/io/trino/plugin/prometheus/TestPrometheusCaseInsensitiveNameMatching.java Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Aug 22, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@lshmouse
Copy link
Contributor Author

@ebyhr Thanks for reviewing~ I had updated the patch, comments and suggestions are welcomed， thx~

@cla-bot
Copy link

cla-bot bot commented Aug 22, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Aug 22, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@lshmouse
Copy link
Contributor Author

@ebyhr The PR has been updated. Thanks for your reviewing~

@lshmouse
Copy link
Contributor Author

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

I have uploaded the CLA file. Any update?

@ebyhr
Copy link
Member

ebyhr commented Aug 29, 2022

@martint Could you confirm CLA from @lshmouse?

@ebyhr
Copy link
Member

ebyhr commented Aug 30, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 30, 2022

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2022
@ebyhr ebyhr merged commit 6a3407e into trinodb:master Aug 30, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 30, 2022

Merged, thanks!

@ebyhr ebyhr mentioned this pull request Aug 30, 2022
Closed
@github-actions github-actions bot added this to the 395 milestone Aug 30, 2022
@colebow colebow mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
395
2 participants
@lshmouse @ebyhr