Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip all-false nulls array in MapBlockBuilder #13710

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

raunaqmorarka
Copy link
Member

Description

Skip all-false nulls array in MapBlockBuilder

Is this change a fix, improvement, new feature, refactoring, or other?

improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

core query engine

How would you describe this change to a non-technical end user or system administrator?

minor performance improvement to operations on MAP data type

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

Copy link
Member

@lukasz-stec lukasz-stec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % test

@raunaqmorarka raunaqmorarka merged commit 5bd6b78 into trinodb:master Aug 17, 2022
@raunaqmorarka raunaqmorarka deleted the map-null branch August 17, 2022 15:50
@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants