Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable creating review on fixup commits #13703

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

nineinchnick
Copy link
Member

Description

Workflows triggered by pull-requests are using a read-only token that
can't create reviews. I think we'd need a Github App for this, and I want to start using one in #12817, so let's wait until that PR gets merged first.

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
ci

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Workflows triggered by pull-requests are using a read-only token that
can't create reviews.
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Unfortunate. But we can try out alternatives.

@hashhar hashhar merged commit f71cb66 into trinodb:master Aug 17, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Aug 23, 2022
@nineinchnick nineinchnick deleted the disable-fixup-checks branch November 2, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

4 participants