Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config exchange.azure.max-error-retries #13663

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

linzebing
Copy link
Member

Description

Is this change a fix, improvement, new feature, refactoring, or other?

New config

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

trino-exchange-filesystem plugin

How would you describe this change to a non-technical end user or system administrator?

This PR allows users to configure the maximum number of request error retries fro Azure-based spooling. Default was 4, now 10.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@arhimondr arhimondr merged commit 8cc953e into trinodb:master Aug 15, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 15, 2022
@colebow
Copy link
Member

colebow commented Aug 15, 2022

I'm going to propose that we add a release note for this:

## General
Add `exchange.azure.max-error-retries` configuration property for the
number of retries performed when accessing Azure blob storage. ({issue}`13663`)

Does that seem ok? And would it be better if it went into a different or more specific section?

@arhimondr
Copy link
Contributor

It looks good to me. @linzebing Do we usually put changes to exchange manager into a dedicated section?

@linzebing
Copy link
Member Author

@colebow: I don't expect most users need to change this config in practice. So I would suggest we don't do a release note for this.

@linzebing linzebing deleted the azure-spooling-configs branch August 17, 2022 14:59
@rijojoseph07
Copy link

Hi @linzebing we are currently using fs.azure.io.retry.max.retries to control retries at the driver level. How is this config different? Thanks

@linzebing
Copy link
Member Author

@rijojoseph07 : This one is set for the client side. I don't know which one takes precedence for Azure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants