Schedule source stages in sequence in FixedSourcePartitionedScheduler #13655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
approved these changes
Aug 12, 2022
Before grouped execution was added, source stages in FixedSourcePartitionedScheduler were scheduled in sequence. When grouped execution got removed that logic was lost. This PR restores the logic so that partitioned queries don't get deadlocked
|
Failed due #13556 |
|
Fails due #13658 |
sopel39
force-pushed
the
ks/fix_deadlock
branch
from
731871e
to
1d19fef
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before grouped execution was added, source stages in FixedSourcePartitionedScheduler
were scheduled in sequence. When grouped execution got removed
that logic was lost. This PR restores the logic so that
partitioned queries don't get deadlocked
Description
fix
core (scheduler)
Prevent queries from deadlocking which was introduced when grouped execution was removed
Related issues, pull requests, and links
Fixes #13652
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: