Reuse type analysis within DomainTranslator.visitComparisonExpression #13562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single invocation of `DomainTranslator.visitComparisonExpression` used to call type analysis 3 times: in `toNormalizedSimpleComparison`, in `isImplicitCoercion` and once directly in `visitComparisonExpression`.
raunaqmorarka
approved these changes
Aug 11, 2022
findepi
deleted the
findepi/reuse-type-analysis-within-domaintranslator-visitcomparisonexpression-e10224
branch
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single invocation of
DomainTranslator.visitComparisonExpressionused to call type analysis 3 times: in
toNormalizedSimpleComparison,in
isImplicitCoercionand once directly invisitComparisonExpression.Extracted from #13567