Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link and port in ClickHouse documentation #13328

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

tylerhannan
Copy link
Contributor

@tylerhannan tylerhannan commented Jul 24, 2022

Description

some extremely minor changes to update the URLs for the website, point to the JDBC driver repository for deeper compatibility information, and resolve an incorrect port in the TLS URL

Is this change a fix, improvement, new feature, refactoring, or other?
Minor docs update

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
n/a

How would you describe this change to a non-technical end user or system administrator?
documentation update

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

@cla-bot
Copy link

cla-bot bot commented Jul 24, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Jul 24, 2022
@tylerhannan
Copy link
Contributor Author

CLA submitted via email

@ebyhr
Copy link
Member

ebyhr commented Jul 25, 2022

Thanks for your contribution! Please follow the commit message guideline: https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@ebyhr ebyhr changed the title Updating URLs, fixing incorrect TLS ports Update link and port in ClickHouse documentation Jul 25, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 17, 2022

@tylerhannan I reverted some change about replacement of driver package because we still need to document it. Let me include only link and port change.

@ebyhr ebyhr merged commit 4ebc3a8 into trinodb:master Aug 17, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 17, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants