Fix disappearance issue of renamed schema in File metastore #13309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
approved these changes
Jul 22, 2022
|
Build is red. |
findepi
reviewed
Jul 22, 2022
| try { | ||
| if (!metadataFileSystem.rename(getDatabaseMetadataDirectory(databaseName), getDatabaseMetadataDirectory(newDatabaseName))) { | ||
| writeSchemaFile(DATABASE, newDatabaseMetadataDirectory, databaseCodec, new DatabaseMetadata(currentVersion, database), false); | ||
| deleteSchemaFile(DATABASE, oldDatabaseMetadataDirectory); |
There was a problem hiding this comment.
@findepi Changed to rename.
ebyhr
force-pushed
the
ebi/hive-rename-schema
branch
from
c3d4460
to
59a0bdc
Compare
ebyhr
force-pushed
the
ebi/hive-rename-schema
branch
from
e1a8da2
to
61c81f7
Compare
Additionally, verify renamed schema existence in BaseConnectorTest.testRenameSchema.
ebyhr
force-pushed
the
ebi/hive-rename-schema
branch
from
61c81f7
to
2e6f68b
Compare
|
CI hit #12405 |
findepi
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix disappearance issue of renamed schema in File metastore
Fixes #13306
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.