Explicitly set argLine property #12928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property is used by Jacoco to store its agent properties; it's then
used in Surefire configuration to paste these properties as JVM command
arguments. Normally this is managed by two profiles in Airbase POM:
`jacoco-check`, which configures the Jacoco plugin to initialize this
property, and `jacoco-defaults`, which sets the property to empty. These
two profiles are activated by the `air.check.skip-all` property being
`false` and `true` respectively.
The problem is, though, that we disable Jacoco by setting
`air.check.skip-jacoco` instead. This means that the Jacoco plugin is
configured, but not executed - and the profile which sets `argLine` to
empty is not activated. This leaves the `argLine` property uinitialized,
and the Surefire configuration ends up having literal `${argLine}` in
the JVM commands. This confuses some tools which rely on this
configuration (though not Surefire itself), including at least one
popular IDE.
| @@ -39,6 +39,9 @@ | |||
| <air.check.skip-spotbugs>true</air.check.skip-spotbugs> | |||
| <air.check.skip-pmd>true</air.check.skip-pmd> | |||
| <air.check.skip-jacoco>true</air.check.skip-jacoco> | |||
| <!-- Jacoco is explicitly disabled, but the profiles setting this property are activated | |||
There was a problem hiding this comment.
Did you mean this?
Suggested change
| <!-- Jacoco is explicitly disabled, but the profiles setting this property are activated | |
| <!-- Jacoco is explicitly disabled, but profiles referencing this property are activated |
There was a problem hiding this comment.
No, these profiles are not referencing argLine, they are initializing it. argLine is referenced in the Surefire configuration.
|
|
This is better fixed in Airbase: airlift/airbase#318. This PR can be considered a temporary workaround until that fix trickles down into Trino. |
|
Obsoleted by #12979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This property is used by Jacoco to store its agent properties; it's then used in Surefire configuration to paste these properties as JVM command arguments. Normally this is managed by two profiles in Airbase POM:
jacoco-check, which configures the Jacoco plugin to initialize this property, andjacoco-defaults, which sets the property to empty. These two profiles are activated by theair.check.skip-allproperty beingfalseandtruerespectively.The problem is, though, that we disable Jacoco by setting
air.check.skip-jacocoinstead. This means that the Jacoco plugin is configured, but not executed - and the profile which setsargLineto empty is not activated. This leaves theargLineproperty uinitialized, and the Surefire configuration ends up having literal${argLine}in the JVM commands. This confuses some tools which rely on this configuration (though not Surefire itself), including at least one popular IDE.Fix.
Build scripts.
Makes some tests work in an IDE.
Related issues, pull requests, and links
airlift/airbase#300
airlift/airbase#301
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: