Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka smoke tests to use Confluent docker image version 7.1.1 #12764

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Update kafka smoke tests to use Confluent docker image version 7.1.1 #12764

merged 1 commit into from
Jun 10, 2022

Conversation

kobihikri
Copy link
Member

@kobihikri kobihikri commented Jun 9, 2022

Description

This PR is to advance the Confluent platform docker images version used by trino kafka plugin in the kafka smoke tests.

This is an improvement as new confluent platform docker images utilize improved, more efficient kafka versions

Is this change a fix, improvement, new feature, refactoring, or other?
This change relates only to the kafka connector smoke tests

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?
Confluent docker images are being used as part of the testing environment for the trino kafka plugin. This change is about "catching up" with the latest version of these images, which utilize higher versions of kafka / zookeeper and schema registry - taking advantage mostly of more efficient code base.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link

cla-bot bot commented Jun 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@ebyhr
Copy link
Member

ebyhr commented Jun 10, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2022
@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Jun 10, 2022
@ebyhr ebyhr merged commit 7c516e5 into trinodb:master Jun 10, 2022
@ebyhr
Copy link
Member

ebyhr commented Jun 10, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 386 milestone Jun 10, 2022
@kobihikri kobihikri deleted the UpdateConfluentDockerImageInKafkaSmokeTest branch June 10, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

Confluent kafka docker image is not up to date (used by testing environment)
2 participants