Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest Kafka test image version to 7.1.1 #12759

Closed
wants to merge 4 commits into from
Closed

Update latest Kafka test image version to 7.1.1 #12759

wants to merge 4 commits into from

Conversation

kobihikri
Copy link
Member

@kobihikri kobihikri commented Jun 9, 2022

Description

This PR is to advance the Confluent platform docker images version used by trio kafka plugin.

Is this change a fix, improvement, new feature, refactoring, or other?
This is an improvement as new confluent platform docker images utilize improved, more efficient kafka versions

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
This change relates only to the kafka connector tests

How would you describe this change to a non-technical end user or system administrator?
Confluent docker images are being used as part of the testing environment for the trino kafka plugin. This change is about "catching up" with the latest version of these images, which utilize higher versions of kafka / zookeeper and schema registry - taking advantage mostly of more efficient code base.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot
Copy link

cla-bot bot commented Jun 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please change the commit title as

Update latest Kafka test image version to 7.1.1

https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@ebyhr ebyhr changed the title confluent image version bump Update latest Kafka test image version to 7.1.1 Jun 9, 2022
…kaLatestConnectorSmokeTest.java

Co-authored-by: Yuya Ebihara <[email protected]>
@cla-bot
Copy link

cla-bot bot commented Jun 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Jun 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@kobihikri kobihikri closed this Jun 9, 2022
@kobihikri
Copy link
Member Author

I am opening a new PR with a single commit and a correct title. Apologies for the inconvenience

@kobihikri kobihikri reopened this Jun 9, 2022
@kobihikri
Copy link
Member Author

Reopening as per request

@kobihikri kobihikri closed this Jun 9, 2022
@ebyhr ebyhr reopened this Jun 9, 2022
@ebyhr ebyhr closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Confluent kafka docker image is not up to date (used by testing environment)
2 participants