Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Airbase to 126 #12560

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Bump Airbase to 126 #12560

merged 1 commit into from
Jun 9, 2022

Conversation

ksobolew
Copy link
Contributor

@ksobolew ksobolew commented May 26, 2022 •
edited
Loading

Description

  • Version 125 brings (among other things) updated dependency on Jackson, which fixes at least one CVE. Dependency on snakeyaml needs to be bumped to avoid conflicts with transitive dependencies.

  • Version 126 brings fixes to how locale information is passed to Maven Surefire plugin. In relation to that, this commit adds a test to verify that the system locale is actually properly configured in the JVM.

Is this change a fix, improvement, new feature, refactoring, or other?

Potential security fix, improvements to test stability.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Everything touching JSON

How would you describe this change to a non-technical end user or system administrator?

Potential security fix, improvements to test stability.

Related issues, pull requests, and links

airlift/airbase#314

airlift/airbase#315

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 26, 2022
@ksobolew
Copy link
Contributor Author

ksobolew commented May 26, 2022 •
edited
Loading

Created as draft without (yet) actually changing the version to see if the newly added test fails in CI. It does fail for me locally (my system locale is pl_PL).

This is no longer relevant because Airbase 125 does not have the fix to locales (see airlift/airbase#315)

@ksobolew ksobolew force-pushed the kudi/bump-airbase branch 2 times, most recently from 033a279 to 4b9f601 Compare May 26, 2022 12:47
@ksobolew ksobolew changed the title Bump Airbase [draft] Bump Airbase to 125 May 26, 2022
@ksobolew ksobolew marked this pull request as ready for review May 26, 2022 12:49
@ksobolew ksobolew requested a review from findepi June 1, 2022 08:46
@ksobolew ksobolew force-pushed the kudi/bump-airbase branch from 4b9f601 to 4516336 Compare June 1, 2022 08:47
findepi
findepi reviewed Jun 1, 2022
View reviewed changes
pom.xml Show resolved Hide resolved
@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 1, 2022 

Terminating due to java.lang.OutOfMemoryError: Java heap space
Error: Process completed with exit code 3.

☹️

@martint
Copy link
Member

martint commented Jun 1, 2022

It's due to a broken version of the surefire plugin: #11900 (comment)

@findepi
Copy link
Member

findepi commented Jun 2, 2022

It's due to a broken version of the surefire plugin: #11900 (comment)

which was supposed to be fixed by airlift/airbase#313.

now that's approved, we can perhaps merge it

@ksobolew ksobolew force-pushed the kudi/bump-airbase branch from 4516336 to a84af73 Compare June 7, 2022 07:50
@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 7, 2022 •
edited
Loading

core/trino-main failed with OOME:

2022-06-07T04:07:35.172-0500	INFO	pool-53-thread-2	io.trino.testng.services.ProgressLoggingListener	[TEST START] io.trino.operator.aggregation.TestTDigestAggregationFunction.testTdigestAggregationFunction
Terminating due to java.lang.OutOfMemoryError: Java heap space
Error: Process completed with exit code 3.

https://github.com/trinodb/trino/runs/6770151334?check_suite_focus=true

@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 7, 2022

plugin/trino-phoenix most likely has some initialization problem:

Caused by: io.trino.spi.TrinoException: line 1:135: Table 'phoenix.tpch.orders' does not exist

I seem to have seen this before.

https://github.com/trinodb/trino/runs/6770154443?check_suite_focus=true

@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 7, 2022

plugin/trino-phoenix most likely has some initialization problem:

Maybe #11344?

@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 8, 2022

Are there plans to release new Airbase version @findepi?

@nineinchnick
Copy link
Member

Are there plans to release new Airbase version @findepi?

It was released yesterday. You can bump this to 126. There's also 127 but it'll require removing a few shaded org.apache imports, I have these changes in #12758 that's testing the latest version of Surefire.

@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 9, 2022

It was released yesterday. You can bump this to 126.

Thanks!

@ksobolew
Bump Airbase to 126
2c5ae45 
* Version 125 brings (among other things) updated dependency on Jackson,
  which fixes at least one CVE. Dependency on snakeyaml needs to be
  bumped to avoid conflicts with transitive dependencies.

* Version 126 brings fixes to how locale information is passed to Maven
  Surefire plugin. In relation to that, this commit adds a test to
  verify that the system locale is actually properly configured in the
  JVM.
@ksobolew ksobolew force-pushed the kudi/bump-airbase branch from a84af73 to 2c5ae45 Compare June 9, 2022 07:51
@ksobolew ksobolew changed the title Bump Airbase to 125 Bump Airbase to 126 Jun 9, 2022
@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 9, 2022

CI hit: #12726

@ksobolew
Copy link
Contributor Author

ksobolew commented Jun 9, 2022

No other failures reported

@findepi findepi requested a review from nineinchnick June 9, 2022 09:38
@nineinchnick nineinchnick mentioned this pull request Jun 9, 2022
Merged
@electrum electrum merged commit dbebd79 into trinodb:master Jun 9, 2022
@github-actions github-actions bot added this to the 386 milestone Jun 9, 2022
@ksobolew ksobolew deleted the kudi/bump-airbase branch June 10, 2022 10:20
@colebow colebow mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasz-walkiewicz lukasz-walkiewicz lukasz-walkiewicz approved these changes

@nineinchnick nineinchnick nineinchnick approved these changes

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
386
Development

Successfully merging this pull request may close these issues.
6 participants
@ksobolew @martint @findepi @nineinchnick @lukasz-walkiewicz @electrum