Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail on X-Forwarded-For by default #1193

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Do not fail on X-Forwarded-For by default #1193

merged 1 commit into from
Jul 30, 2019

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 26, 2019 •
edited
Loading

See discussion in #1189

Fixes #1189

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2019
@findepi
Copy link
Member Author

findepi commented Jul 26, 2019

"WIP" -- until #1189 discussion is concluded.

@findepi findepi added the WIP label Jul 26, 2019
electrum
electrum approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Let's see if others agree this is the right approach.

@vrozov
Copy link
Contributor

vrozov commented Jul 29, 2019

👍

@findepi findepi removed the WIP label Jul 30, 2019
@findepi findepi merged commit 84258c5 into trinodb:master Jul 30, 2019
@findepi findepi deleted the findepi/master/do-not-fail-on-x-forwarded-for-by-default-7b5ec1 branch July 30, 2019 18:56
@findepi findepi mentioned this pull request Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for X-Forwarded-For breaks existing behavior
3 participants
@findepi @vrozov @electrum