Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate tracing from PrestoDB #11244

Closed
wants to merge 3 commits into from
Closed

Conversation

jerryleooo
Copy link
Member

@jerryleooo jerryleooo commented Mar 1, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

This is a new feature that supports tracing in Trino.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

This mainly adds tracer along with the query, so some interfaces and dependencies are changed. Actually this mainly borrowed from PrestoDB.

How would you describe this change to a non-technical end user or system administrator?

With a tracer along with the query, we can understand the time spent in each stage, so easier for us to find the potential performance bottleneck.

Related issues, pull requests, and links

#1826
#2010
#4207
#9924
#11157

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
(x) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Section
* Adding tracer along with queries. ({issue}`11244`)

@cla-bot cla-bot bot added the cla-signed label Mar 1, 2022
@jerryleooo jerryleooo changed the title migrate tracing from Presto WIP: migrate tracing from Presto Mar 1, 2022
@jerryleooo jerryleooo marked this pull request as draft March 1, 2022 08:41
@jerryleooo jerryleooo force-pushed the tracing branch 2 times, most recently from e4b10e8 to eba00bb Compare March 3, 2022 02:14
@jerryleooo jerryleooo changed the title WIP: migrate tracing from Presto WIP: migrate tracing from PrestoDB Mar 4, 2022
@jerryleooo jerryleooo marked this pull request as ready for review March 12, 2022 11:00
@jerryleooo jerryleooo changed the title WIP: migrate tracing from PrestoDB migrate tracing from PrestoDB Mar 12, 2022
@martint
Copy link
Member

martint commented Sep 23, 2022

Thanks for your contribution. However, we have other plans to add tracing support with OpenTelemetry instead of the approach proposed here. By using OpenTelemetry, we get better integrations with a vast ecosystem of observability tools.

@martint martint closed this Sep 23, 2022
@martint
Copy link
Member

martint commented Sep 23, 2022

Thanks for your contribution. However, we have other plans to add tracing support with OpenTelemetry instead of the approach proposed here. By using OpenTelemetry, we get better integrations with a vast ecosystem of observability tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants