Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for KuduClientConfig #11053

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 16, 2022

Description

Add test for KuduClientConfig

General information

Maintenance

Related issues, pull requests, and links

n/a

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Feb 16, 2022
@ebyhr ebyhr added the maintenance Project maintenance task label Feb 16, 2022
@ebyhr
Copy link
Member Author

ebyhr commented Feb 16, 2022

CI #11054

Additionally, set empty list for kudu.client.master-addresses
by default in KuduClientConfig.
@ebyhr ebyhr force-pushed the ebi/kudu-test-config branch from ba8197c to 736a5bc Compare February 16, 2022 05:53
@ebyhr
Copy link
Member Author

ebyhr commented Feb 16, 2022

CI (trino-oracle) #11057

@ebyhr ebyhr requested a review from hashhar February 16, 2022 07:06
Copy link
Contributor

@grantatspothero grantatspothero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this, I noticed these tests were missing but did not want to add them to the [already large PR] I was working on.

@hashhar hashhar merged commit 374ce06 into trinodb:master Feb 16, 2022
@github-actions github-actions bot added this to the 371 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed maintenance Project maintenance task
Development

Successfully merging this pull request may close these issues.

3 participants