Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong row values in column channel in tpcds queries q05, q14, q49, q76, q80 #11018

Merged

Conversation

przemekak
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 11, 2022
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did problem manifest?

@losipiuk
Copy link
Member

Probably better commit name would be:
Fix column alias in TPC-DS queries q05, q14, q49, q76, q80

@przemekak
Copy link
Member Author

przemekak commented Feb 11, 2022

@losipiuk
Result would contain name of the used catalog and schema instead of just the name of collection:
e.g.:

tpcds.sf10.store,71637,0.0000,1,83
tpcds.sf10.store,53513,0.0000,1,94
tpcds.sf10.store,55395,0.6327,3,2
tpcds.sf10.store,5537,0.6495,4,1

So we would have different results for such queries if we use different connector/schema.
And column name was stable, actual values in columns channel are different.

@findepi
Copy link
Member

findepi commented Feb 11, 2022

Fix column alias in TPC-DS queries q05, q14, q49, q76, q80

note that it's not alias what changed.

@losipiuk
Copy link
Member

Fix column alias in TPC-DS queries q05, q14, q49, q76, q80

note that it's not alias what changed.

Yeah - right - my bad.

@findepi findepi merged commit 8ea7507 into trinodb:master Feb 12, 2022
@findepi findepi deleted the przemekak/fix-tpcds-benchmark-queries branch February 12, 2022 16:12
@github-actions github-actions bot added this to the 371 milestone Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants