Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to TEXTFILE for LazySimpleSerDe and SymlinkTextInputFormat #11003

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Feb 10, 2022

Per Hive spec symlinks should default to TEXTFILE
(https://hive.apache.org/javadocs/r2.1.1/api/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.html).
However Databricks Delta uses symlinks to point to Parquet files.
Snowflake and Redshift Spectrum now also support the same non-standard use of Parquet+Symlink.
Hence this PR defaults symlinks to TEXTFILE only for LazySimpleSerDe
which is used by both TEXTFILE and SEQUENCEFILE.

Fixes: #10910

Per Hive spec symlinks should default to TEXTFILE
(https://hive.apache.org/javadocs/r2.1.1/api/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.html).
However Databricks Delta uses symlinks to point to Parquet files.
Snowflake and Redshift Spectrum now also support the same non-standard use of Parquet+Symlink.
Hence this PR defaults symlinks to TEXTFILE only for LazySimpleSerDe
which is used by both TEXTFILE and SEQUENCEFILE.
@sopel39 sopel39 merged commit e4153b0 into trinodb:master Feb 11, 2022
@sopel39 sopel39 deleted the ks/simlink branch February 11, 2022 10:03
@sopel39 sopel39 mentioned this pull request Feb 11, 2022
@github-actions github-actions bot added this to the 371 milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

SymlinkTextInputFormat defaults to input format as SEQUENCEFILE
2 participants