Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define session and catalog session properties #10998

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Feb 9, 2022

Description

Add a definition for session properties and catalog session properties to the SET SESSION documentation, and link to that definition from the most relevant pages.

General information

Is this change a fix, improvement, new feature, refactoring, or other?

Docs improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Define session and catalog session properties in the documentation

Related issues, pull requests, and links

N/A

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text

@cla-bot cla-bot bot added the cla-signed label Feb 9, 2022
@jhlodin jhlodin requested review from mosabua and electrum February 9, 2022 18:19
@jhlodin jhlodin added the docs label Feb 9, 2022
@jhlodin jhlodin requested review from Ordinant and Jessie212 February 9, 2022 18:19
Copy link
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite nearly flawless, but questions are open.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed. Thanks.

docs/src/main/sphinx/sql/set-session.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-session.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-session.rst Outdated Show resolved Hide resolved
@jhlodin jhlodin force-pushed the jl/set-session-properties branch from 743841c to 879fdae Compare February 10, 2022 17:58
@jhlodin jhlodin requested review from Ordinant and hashhar February 10, 2022 18:01
docs/src/main/sphinx/sql/set-session.rst Outdated Show resolved Hide resolved
@jhlodin jhlodin force-pushed the jl/set-session-properties branch from 879fdae to 6de3a20 Compare February 10, 2022 19:26
@hashhar
Copy link
Member

hashhar commented Feb 10, 2022

@mosabua @Ordinant Any remaining comments or should I go ahead and merge this?

Copy link
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last plea against inherited text for clarity.

@jhlodin jhlodin force-pushed the jl/set-session-properties branch from 6de3a20 to ce25ce4 Compare February 10, 2022 22:26
@hashhar hashhar merged commit 19fe2c7 into trinodb:master Feb 11, 2022
@github-actions github-actions bot added this to the 371 milestone Feb 11, 2022
@jhlodin jhlodin deleted the jl/set-session-properties branch February 11, 2022 14:36
@jhlodin jhlodin restored the jl/set-session-properties branch February 11, 2022 16:36
@jhlodin jhlodin deleted the jl/set-session-properties branch September 2, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants