Ignore invalid views when listing in Hive connector #10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
approved these changes
Feb 2, 2022
hashhar
reviewed
Feb 2, 2022
| @@ -2371,6 +2372,9 @@ public void dropView(ConnectorSession session, SchemaTableName viewName) | |||
| if (e.getErrorCode().equals(HIVE_VIEW_TRANSLATION_ERROR.toErrorCode())) { | |||
| // Ignore hive views for which translation fails | |||
| } | |||
| else if (e.getErrorCode().equals(HIVE_INVALID_VIEW_DATA.toErrorCode())) { | |||
| // Ignore views that are not valid | |||
There was a problem hiding this comment.
In this entire block we should be logging (ideally at WARN otherwise DEBUG).
There was a problem hiding this comment.
I'm not sure. This means every metadata call will log potentially many times, flooding the logs. You'll see the actual error if you try to query the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.