-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failure when matching empty dictionary #10873
Conversation
8aa5496
to
615f675
Compare
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Show resolved
Hide resolved
The CI didn't run here. |
Any plan to merge this soon? |
Hi, with that fix applied Trino returns us 0 rows, when perform
|
lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
b27528c
to
4e5df34
Compare
@kantonczak, can you try with the latest updates to this PR? |
+1 on this issue and fix, this issue is preventing me from migrating from Presto to Trino. |
@martint the issue can be reproduced by writing a parquet file with pyarrow: import pyarrow
from pyarrow import parquet
with open("foo.parquet", "wb") as fp:
parquet.write_table(pyarrow.Table.from_arrays([pyarrow.array([None,None,None,None])], names=["x"]), fp) I will send the parquet file in trino slack. Repro query: CREATE TABLE test_null_parquet (x VARCHAR) WITH (format='PARQUET', external_location='s3a://.../foo.parquet');
SELECT * FROM test_null_parquet WHERE x IS NULL;
Query 20220817_185451_00007_yq9np, FAILED, 1 node
Splits: 5 total, 0 done (0.00%)
1.76 [0 rows, 0B] [0 rows/s, 0B/s]
Query 20220817_185451_00007_yq9np failed: Error opening Hive split s3a://.../nick/foo/myparquet.parquet (offset=0, length=408): cannot use empty rangeList |
77a4294
to
d4f36e2
Compare
c10a162
to
6a7594c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, minor comments
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
6a7594c
to
9122fe8
Compare
Fixes #9424
Release note: