-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe support of CHAR/VARCHAR predicate pushdown #10110
Conversation
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
d40b656
to
6443bb0
Compare
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
6443bb0
to
fa30aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fragments might be misleading since they have incomplete information. Maybe they should be titled Predicate pushdown limitations
(even then they are incomplete though)?
Looks good % comments.
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
fa30aed
to
5544d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion to rename the fragments since it's not obvious what their contents are it's easy to place the wrong one in the wrong doc.
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
5544d24
to
2db979d
Compare
Add documentation for limitations around certain connectors pushing down predicates on CHAR/VARCHAR type columns.