Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe support of CHAR/VARCHAR predicate pushdown #10110

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Nov 29, 2021

Add documentation for limitations around certain connectors pushing down predicates on CHAR/VARCHAR type columns.

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2021
@jhlodin jhlodin requested review from mosabua, ebyhr and hashhar and removed request for mosabua November 29, 2021 23:46
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fragments might be misleading since they have incomplete information. Maybe they should be titled Predicate pushdown limitations (even then they are incomplete though)?

Looks good % comments.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion to rename the fragments since it's not obvious what their contents are it's easy to place the wrong one in the wrong doc.

@hashhar hashhar merged commit 7d9f189 into trinodb:master Dec 3, 2021
@jhlodin jhlodin deleted the jl/pushdown-char-varchar branch December 3, 2021 17:21
@github-actions github-actions bot added this to the 365 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants