Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UUID type in PostgreSQL connector #1011

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Add support for UUID type in PostgreSQL connector #1011

merged 1 commit into from
Jun 18, 2019

Conversation

pgagnon
Copy link
Member

@pgagnon pgagnon commented Jun 17, 2019

Closes #647

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2019
@pgagnon pgagnon changed the title Add Postgresql UUID support Add support for UUID type in PostgreSQL connector Jun 17, 2019
@pgagnon pgagnon mentioned this pull request Jun 17, 2019
Closed
electrum
electrum reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java Outdated Show resolved Hide resolved
@pgagnon pgagnon force-pushed the postgres-uuid branch 2 times, most recently from 02f48a4 to 96458ce Compare June 17, 2019 10:42
electrum
electrum reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the tests were failing because TestingPrestoClient doesn't have support for UUID. This should fix it:

else if (UUID.equals(type)) {
    return java.util.UUID.fromString((String) value);
}

Note that you can run the test method or test class by clicking the green arrow next to it in IntelliJ.

presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java Outdated Show resolved Hide resolved
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java Outdated Show resolved Hide resolved
@pgagnon
Copy link
Member Author

pgagnon commented Jun 18, 2019

CI has passed. 🎉

@electrum electrum added this to the 316 milestone Jun 18, 2019
@electrum electrum merged commit b669b57 into trinodb:master Jun 18, 2019
@electrum
Copy link
Member

Merged, thanks!

@pgagnon pgagnon mentioned this pull request Jul 4, 2019
Closed
6 tasks
@pgagnon pgagnon deleted the postgres-uuid branch July 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr left review comments

@electrum electrum electrum left review comments

Assignees
No one assigned
Labels
cla-signed
Milestone
316
Development

Successfully merging this pull request may close these issues.

Support UUID in PostgreSQL connector
3 participants
@pgagnon @electrum @ebyhr