Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecations in Parquet #1802

Open
findepi opened this issue Oct 18, 2019 · 2 comments
Open

Resolve deprecations in Parquet #1802

findepi opened this issue Oct 18, 2019 · 2 comments
Labels
good first issue Good for newcomers maintenance Project maintenance task

Comments

@findepi
Copy link
Member

findepi commented Oct 18, 2019 •
edited
Loading

presto-orc has very few deprecation warnings and these are probably unavoidable (related to #37)

however presto-parquet has many more. We should resolve them, as they often signal upcoming breaking changes.
@findepi
Copy link
Member Author

findepi commented Oct 18, 2019

Some deprecations may be easy to fix (i already fixed some trivial ones).

Some require more thought, like Binary.fromByteArray.
If anyone works on this, please fix one kind of a warning at a time.

@findepi findepi changed the title Resolve deprecations in ORC, Parquet Resolve deprecations in Parquet Oct 18, 2019
@findepi findepi added the maintenance Project maintenance task label Oct 19, 2019
@kokosing kokosing added the good first issue Good for newcomers label Oct 21, 2019
@findepi findepi mentioned this issue Oct 23, 2019
Closed
@findepi
Copy link
Member Author

findepi commented Oct 23, 2019

org.apache.parquet.hadoop.metadata.ColumnChunkMetaData#getPath deprecation is reverted in upstream, so this needs to stay for now.

@findepi findepi self-assigned this Oct 23, 2019
@findepi findepi removed their assignment Nov 4, 2020
nevillelyh added a commit to nevillelyh/trino that referenced this issue Aug 8, 2022
@nevillelyh
Fix deprecated OriginalType in trino-parquet trinodb#1802
9601c74 
- Replace OriginalType with LogicalTypeAnnotation whenever possible
- Kept parts of MessageTypeConverter and MetadataReader since they're
  needed for compatibility reasons
nevillelyh added a commit to nevillelyh/trino that referenced this issue Aug 8, 2022
@nevillelyh
Fix deprecated OriginalType in trino-hive trinodb#1802
599bc28 
- Replace OriginalType with LogicalTypeAnnotation whenever possible
- Refactor test list & map wrappers for consistency
This was referenced Aug 8, 2022
Closed
Closed
Merged
@nevillelyh nevillelyh mentioned this issue Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Project maintenance task
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parquet code fixes findepi/trino
2 participants
@findepi @kokosing