Remove unused Hive allow-corrupt-writes config

trinodb · Jun 2, 2021 · ff4a1e3 · ff4a1e3
1 parent c637346
commit ff4a1e3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 20 deletions.
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveConfig.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveConfig.java
@@ -52,6 +52,7 @@
         "hive.time-zone",
         "hive.assume-canonical-partition-keys",
         "hive.partition-use-column-names",
+        "hive.allow-corrupt-writes-for-testing",
 })
 public class HiveConfig
 {
@@ -78,8 +79,6 @@ public class HiveConfig
     private int maxConcurrentMetastoreDrops = 20;
     private int maxConcurrentMetastoreUpdates = 20;
 
-    private boolean allowCorruptWritesForTesting;
-
     private long perTransactionMetastoreCacheMaximumSize = 1000;
 
     private HiveStorageFormat hiveStorageFormat = HiveStorageFormat.ORC;
@@ -373,21 +372,6 @@ public HiveConfig setMaxSplitIteratorThreads(int maxSplitIteratorThreads)
         return this;
     }
 
-    @Deprecated
-    public boolean getAllowCorruptWritesForTesting()
-    {
-        return allowCorruptWritesForTesting;
-    }
-
-    @Deprecated
-    @Config("hive.allow-corrupt-writes-for-testing")
-    @ConfigDescription("Allow Hive connector to write data even when data will likely be corrupt")
-    public HiveConfig setAllowCorruptWritesForTesting(boolean allowCorruptWritesForTesting)
-    {
-        this.allowCorruptWritesForTesting = allowCorruptWritesForTesting;
-        return this;
-    }
-
     @Min(1)
     public long getPerTransactionMetastoreCacheMaximumSize()
     {

diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConfig.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConfig.java
@@ -41,7 +41,6 @@ public void testDefaults()
                 .setMaxOutstandingSplits(1_000)
                 .setMaxOutstandingSplitsSize(DataSize.of(256, Unit.MEGABYTE))
                 .setMaxSplitIteratorThreads(1_000)
-                .setAllowCorruptWritesForTesting(false)
                 .setPerTransactionMetastoreCacheMaximumSize(1000)
                 .setMinPartitionBatchSize(10)
                 .setMaxPartitionBatchSize(100)
@@ -114,7 +113,6 @@ public void testExplicitPropertyMappings()
                 .put("hive.max-outstanding-splits", "10")
                 .put("hive.max-outstanding-splits-size", "32MB")
                 .put("hive.max-split-iterator-threads", "10")
-                .put("hive.allow-corrupt-writes-for-testing", "true")
                 .put("hive.per-transaction-metastore-cache-maximum-size", "500")
                 .put("hive.metastore.partition-batch-size.min", "1")
                 .put("hive.metastore.partition-batch-size.max", "1000")
@@ -184,7 +182,6 @@ public void testExplicitPropertyMappings()
                 .setMaxOutstandingSplits(10)
                 .setMaxOutstandingSplitsSize(DataSize.of(32, Unit.MEGABYTE))
                 .setMaxSplitIteratorThreads(10)
-                .setAllowCorruptWritesForTesting(true)
                 .setPerTransactionMetastoreCacheMaximumSize(500)
                 .setMinPartitionBatchSize(1)
                 .setMaxPartitionBatchSize(1000)