Skip to content

Commit

Permalink
Rename PageJoiner to DefaultPageJoiner
Browse files Browse the repository at this point in the history
  • Loading branch information
sopel39 committed Jun 2, 2021
1 parent 022a266 commit f2f7ace
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@
import static java.lang.String.format;
import static java.util.Objects.requireNonNull;

public class PageJoiner
public class DefaultPageJoiner
implements WorkProcessor.Transformation<Page, Page>
{
public interface PageJoinerFactory
{
PageJoiner getPageJoiner(
DefaultPageJoiner getPageJoiner(
ListenableFuture<LookupSourceProvider> lookupSourceProvider,
Optional<PartitioningSpillerFactory> partitioningSpillerFactory,
Iterator<SavedRow> savedRows);
Expand Down Expand Up @@ -96,7 +96,7 @@ PageJoiner getPageJoiner(
private Optional<PartitioningSpiller> spiller = Optional.empty();
private ListenableFuture<?> spillInProgress = NOT_BLOCKED;

public PageJoiner(
public DefaultPageJoiner(
ProcessorContext processorContext,
List<Type> probeTypes,
List<Type> buildOutputTypes,
Expand Down Expand Up @@ -433,18 +433,18 @@ public static class SavedRow
public final Page row;

/**
* A snapshot of {@link PageJoiner#joinPosition} "de-partitioned", i.e. {@link PageJoiner#joinPosition} is a join position
* A snapshot of {@link DefaultPageJoiner#joinPosition} "de-partitioned", i.e. {@link DefaultPageJoiner#joinPosition} is a join position
* with respect to (potentially) partitioned lookup source, while this value is a join position with respect to containing partition.
*/
public final long joinPositionWithinPartition;

/**
* A snapshot of {@link PageJoiner#currentProbePositionProducedRow}
* A snapshot of {@link DefaultPageJoiner#currentProbePositionProducedRow}
*/
public final boolean currentProbePositionProducedRow;

/**
* A snapshot of {@link PageJoiner#joinSourcePositions}
* A snapshot of {@link DefaultPageJoiner#joinSourcePositions}
*/
public final int joinSourcePositions;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import io.trino.operator.ProcessorContext;
import io.trino.operator.WorkProcessor;
import io.trino.operator.WorkProcessorOperatorAdapter.AdapterWorkProcessorOperator;
import io.trino.operator.join.DefaultPageJoiner.PageJoinerFactory;
import io.trino.operator.join.JoinProbe.JoinProbeFactory;
import io.trino.operator.join.LookupJoinOperatorFactory.JoinType;
import io.trino.operator.join.PageJoiner.PageJoinerFactory;
import io.trino.spi.Page;
import io.trino.spi.type.Type;
import io.trino.spiller.PartitioningSpillerFactory;
Expand Down Expand Up @@ -63,7 +63,7 @@ public class LookupJoinOperator
lookupSourceProviderFuture = lookupSourceFactory.createLookupSourceProvider();
pageBuffer = new PageBuffer();
PageJoinerFactory pageJoinerFactory = (lookupSourceProvider, joinerPartitioningSpillerFactory, savedRows) ->
new PageJoiner(
new DefaultPageJoiner(
processorContext,
probeTypes,
buildOutputTypes,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
import io.trino.operator.WorkProcessor;
import io.trino.operator.join.PageJoiner.PageJoinerFactory;
import io.trino.operator.join.PageJoiner.SavedRow;
import io.trino.operator.join.DefaultPageJoiner.PageJoinerFactory;
import io.trino.operator.join.DefaultPageJoiner.SavedRow;
import io.trino.spi.Page;
import io.trino.spiller.PartitioningSpillerFactory;

Expand All @@ -45,7 +45,7 @@ public class SpillingJoinProcessor
private final LookupSourceFactory lookupSourceFactory;
private final ListenableFuture<LookupSourceProvider> lookupSourceProvider;
private final PageJoinerFactory pageJoinerFactory;
private final PageJoiner sourcePagesJoiner;
private final DefaultPageJoiner sourcePagesJoiner;
private final WorkProcessor<Page> joinedSourcePages;

private boolean closed;
Expand Down

0 comments on commit f2f7ace

Please sign in to comment.