Quote column name in Phoenix CREATE TABLE statement

Additionally, enable testColumnName test in Phoenix.
trinodb · May 5, 2020 · acd1cfa · acd1cfa
1 parent b1a2969
commit acd1cfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/presto-phoenix/src/main/java/io/prestosql/plugin/phoenix/PhoenixMetadata.java b/presto-phoenix/src/main/java/io/prestosql/plugin/phoenix/PhoenixMetadata.java
@@ -351,7 +351,7 @@ private JdbcOutputTableHandle createTable(ConnectorSession session, ConnectorTab
                     typeStatement += " not null";
                     pkNames.add(columnName);
                 }
-                columnList.add(format("%s %s", columnName, typeStatement));
+                columnList.add(format("%s %s", getEscapedArgument(columnName), typeStatement));
             }
 
             ImmutableList.Builder<String> tableOptions = ImmutableList.builder();

diff --git a/presto-phoenix/src/test/java/io/prestosql/plugin/phoenix/TestPhoenixDistributedQueries.java b/presto-phoenix/src/test/java/io/prestosql/plugin/phoenix/TestPhoenixDistributedQueries.java
@@ -134,10 +134,9 @@ public void testCreateSchema()
     }
 
     @Override
-    public void testColumnName(String columnName)
+    protected boolean isColumnNameRejected(Exception exception, String columnName, boolean delimited)
     {
-        // TODO (https://github.com/prestosql/presto/issues/3466) Phoenix generally lacks quoting in underlying queries
-        throw new SkipException("TODO");
+        return columnName.equals("a\"quote");
     }
 
     @Override