Run storage_formats for kerberized HDFS without impersonation

trinodb · Mar 9, 2020 · ac1b602 · ac1b602
1 parent c0d69ec
commit ac1b602
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
@@ -659,21 +659,6 @@ private List<String> listSchemas(ConnectorSession session, Optional<String> sche
         return listSchemaNames(session);
     }
 
-    private static boolean filterSchema(String schemaName)
-    {
-        if ("information_schema".equals(schemaName)) {
-            // For things like listing columns in information_schema.columns table, we need to explicitly filter out Hive's own information_schema.
-            // TODO https://github.com/prestosql/presto/issues/1559 this should be filtered out in engine.
-            return false;
-        }
-        if ("sys".equals(schemaName)) {
-            // Hive 3's `sys` schema contains no objects we can handle, so there is no point in exposing it.
-            // Also, exposing it may require proper handling in access control.
-            return false;
-        }
-        return true;
-    }
-
     @Override
     public Map<String, ColumnHandle> getColumnHandles(ConnectorSession session, ConnectorTableHandle tableHandle)
     {
@@ -1777,6 +1762,21 @@ private boolean isHiveOrPrestoView(Table table)
         return table.getTableType().equals(TableType.VIRTUAL_VIEW.name());
     }
 
+    private static boolean filterSchema(String schemaName)
+    {
+        if ("information_schema".equals(schemaName)) {
+            // For things like listing columns in information_schema.columns table, we need to explicitly filter out Hive's own information_schema.
+            // TODO https://github.com/prestosql/presto/issues/1559 this should be filtered out in engine.
+            return false;
+        }
+        if ("sys".equals(schemaName)) {
+            // Hive 3's `sys` schema contains no objects we can handle, so there is no point in exposing it.
+            // Also, exposing it may require proper handling in access control.
+            return false;
+        }
+        return true;
+    }
+
     @Override
     public ConnectorTableHandle beginDelete(ConnectorSession session, ConnectorTableHandle tableHandle)
     {

diff --git a/presto-product-tests/bin/product-tests-suite-2.sh b/presto-product-tests/bin/product-tests-suite-2.sh
@@ -11,7 +11,7 @@ presto-product-tests-launcher/bin/run-launcher test run \
 
 presto-product-tests-launcher/bin/run-launcher test run \
     --environment singlenode-kerberos-hdfs-no-impersonation \
-    -- -g hdfs_no_impersonation \
+    -- -g storage_formats,hdfs_no_impersonation \
     || suite_exit_code=1
 
 presto-product-tests-launcher/bin/run-launcher test run \